Skip to content

Conversation

@domesticmouse
Copy link
Contributor

@domesticmouse domesticmouse commented Aug 15, 2025

Upgrade the version of google_sign_in

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the google_sign_in dependency and removes the prerelease flag from the Dart SDK constraint. However, it also introduces significant changes by removing the in_app_purchase and in_app_purchase_platform_interface packages across multiple codelab steps. These removals are not documented in the pull request description, which is currently empty. This lack of context makes it difficult to review and poses a risk to the project's functionality. Please provide a detailed description explaining the rationale for these changes.

@domesticmouse domesticmouse marked this pull request as draft August 15, 2025 20:40
@domesticmouse domesticmouse marked this pull request as ready for review August 17, 2025 18:45
@domesticmouse domesticmouse merged commit 60afd33 into flutter:main Aug 18, 2025
18 of 19 checks passed
@domesticmouse domesticmouse deleted the update-google_sign_in-attempt-2 branch August 18, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants